Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiber.pick does not cancel the other task #57

Open
dinosaure opened this issue Jan 11, 2024 · 0 comments
Open

Fiber.pick does not cancel the other task #57

dinosaure opened this issue Jan 11, 2024 · 0 comments
Labels
invalid This doesn't seem right

Comments

@dinosaure
Copy link
Owner

Actually, Fiber‧pick does not follow the same semantic than Lwt‧pick: it does not cancel the other task when the first one is resolved. It's not a problem as is for the client but it should be for the server (about allocation made by of the other task). We probably should clarify that and see if the usage of it is correct. At least, we should rename it Fiber‧choose.

@dinosaure dinosaure added the invalid This doesn't seem right label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant