Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unreachable-types rule does not consider wrapped request directive argument types #1937

Open
4 tasks
keijokapp opened this issue Oct 17, 2023 · 1 comment
Open
4 tasks
Labels
kind/bug Bug :-( stage/3-local-solution A user has a possible solution that solves the issue

Comments

@keijokapp
Copy link

keijokapp commented Oct 17, 2023

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    For example, you can start off by editng the
    'basic' example on Stackblitz.

    Please make sure the graphql-eslint version under package.json matches yours.

  • 2. A failing test has been provided

  • 3. A local solution has been provided

  • 4. A pull request is pending review


no-unreachable-types rule does not consider wrapped request directive argument types (ie non-null and list types). It skips wrapped types (due to missing name) instead of trying to resolve the name.

The fix, including the test, is at keijokapp@e2d9153

Environment:

  • OS: Linux
  • @graphql-eslint/eslint-plugin: 3.20.1, 4.0.0-alpha.0, master (e854103)
  • Node.js: v20.8.0
@dimaMachina
Copy link
Owner

Nice, sounds like a bug, will be fixed before releasing v4

@dimaMachina dimaMachina added stage/3-local-solution A user has a possible solution that solves the issue kind/bug Bug :-( labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug :-( stage/3-local-solution A user has a possible solution that solves the issue
Projects
None yet
Development

No branches or pull requests

2 participants