Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy as Helm chart #381

Open
tyranron opened this issue Feb 15, 2021 · 7 comments · May be fixed by #382
Open

Deploy as Helm chart #381

tyranron opened this issue Feb 15, 2021 · 7 comments · May be fixed by #382

Comments

@tyranron
Copy link

It would be nice to have an ability to deploy this CSI driver via Helm chart instead of raw Kubernetes manifests. Is it something desirable to be contributed?

@adamwg
Copy link
Contributor

adamwg commented Feb 16, 2021

I would have no objections to adding a helm chart. Interested in @timoreimann's opinion as well.

My only request if we add a helm chart is that we still provide static manifests for those who choose to install that way, and that those static manifests are generated from the helm chart in an automated or semi-automated way for each release (at the very least, we add a CI check that prevents them from being modified separately). I think our static manifests are probably sufficient for the majority of users, but maintaining two separate sets of deployment manifests is obviously a bad idea.

@timoreimann
Copy link
Collaborator

Hey @tyranron 👋

agreeing to all points that @adamwg raised. Something I'm not too familiar with is whether Helm charts should be hosted in this repo, or whether there's possibly a more central place. I'm okay with whatever is state-of-the-Helm-art today.

We do not consume Helm charts internally at DO for the CSI driver, so the best way to support them is for an external contributor to make the initial contribution -- PRs welcome.

@viveksinghggits
Copy link

viveksinghggits commented Apr 5, 2021

Hi @timoreimann,
I was thinking that I can pick this up. Since a lot of projects are hosting the helm charts in their own repo now a days, we can consider hosting the chart here itself.
What do you think?

@timoreimann
Copy link
Collaborator

@viveksinghggits sounds good to me. Feel free to take a stab, I'd be happy to review.

@tyranron
Copy link
Author

tyranron commented Apr 5, 2021

@timoreimann @viveksinghggits actually, I have some ready Helm chart, which we use internally. So for @viveksinghggits not having a fresh start, I'll issue a PR shortly, where will give him access to the branch.

@viveksinghggits
Copy link

@tyranron
that makes sense. Thanks.

@tyranron tyranron linked a pull request Apr 6, 2021 that will close this issue
@viveksinghggits
Copy link

Hey @tyranron/ @timoreimann ,
I thought that I would be able to work on this, but considering recent commitments at work it looks like I will not be able to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants