Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

links to Actions with Maybe's get literal Just in query params #1671

Open
unhammer opened this issue May 18, 2023 · 1 comment · May be fixed by #1691
Open

links to Actions with Maybe's get literal Just in query params #1671

unhammer opened this issue May 18, 2023 · 1 comment · May be fixed by #1691

Comments

@unhammer
Copy link
Contributor

If I do

 | NewThingAction { redirect :: Maybe (Id Other) }

and

        <a href={NewThingAction (Just user.id)}>New</a>

I get an unusable link

<a href="http://localhost:8000/NewThing?redirect=Just03142938-62d5-4de1-af90-49726ca98f35">

where I would expect

<a href="http://localhost:8000/NewThing?redirect=03142938-62d5-4de1-af90-49726ca98f35">

for the Just case and

<a href="http://localhost:8000/NewThing">

for the Nothing case
@amitaibu amitaibu linked a pull request Jun 2, 2023 that will close this issue
Open
3 tasks
@amitaibu
Copy link
Collaborator

amitaibu commented Jun 2, 2023

Started a PR in #1691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow pathTo and parse to work with Maybe (Id record) amitaibu/ihp
2 participants
@unhammer @amitaibu