Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next iteration of fetch_data connectors concept #1524

Open
Tracked by #1521
anthony-chaudhary opened this issue Aug 14, 2023 · 0 comments
Open
Tracked by #1521

Next iteration of fetch_data connectors concept #1524

anthony-chaudhary opened this issue Aug 14, 2023 · 0 comments

Comments

@anthony-chaudhary
Copy link
Member

Current Issues

While working on #1523 there were a few challenges:

  • The return type of objections using the connector pattern felt brittle and hard to update.
    1d4da2b
    Prior used the unclear string result which created bad coupling and assumptions. For example for error checking, is result expected to always be present or not?

  • Error handling and passing of objects generally was hard to think about. It would seem like sometimes we would be doing similar error checking in multiple places.

  • It was hard to follow code becuase fetch data uses string to test the approach.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant