Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIToS should avoid push! calls #29

Open
diegozea opened this issue Jun 21, 2016 · 1 comment
Open

MIToS should avoid push! calls #29

diegozea opened this issue Jun 21, 2016 · 1 comment
Labels
good first issue help wanted

Comments

@diegozea
Copy link
Owner

diegozea commented Jun 21, 2016 •
edited

...when it's possible to gain performance: JuliaLang/julia#5364
@diegozea diegozea added this to the MIToS 2.0 milestone Jun 22, 2016
@diegozea diegozea modified the milestones: MIToS 2.0, MIToS 1.1 Jul 7, 2016
@diegozea diegozea removed this from the MIToS 2.0 milestone Oct 16, 2017
@diegozea
Copy link
Owner Author

It was taken into account when MIToS 2.0 was written. However, the private function MIToS.PDB._get_plane() makes an intensive use of push! and It could be optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diegozea