Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCR Issue/Bug/Error! Comma read as decimal point, leads to Wrong Pot's and Chips #178

Open
keithorange opened this issue May 6, 2023 · 3 comments · May be fixed by #195
Open

OCR Issue/Bug/Error! Comma read as decimal point, leads to Wrong Pot's and Chips #178

keithorange opened this issue May 6, 2023 · 3 comments · May be fixed by #195

Comments

@keithorange
Copy link

keithorange commented May 6, 2023

Describe the bug
While running PokerStars I was reading the output and realized that 30-50% of the time, the OCR captures a comma (,) as a dot (.) leading to pots and funds like $1,420 being read as $1.42. This is a big issue but can probably be fixed quickly,

Next Steps
Do you have a potential fix? I have some ideas (a) retrain ocr for table mapping b) brute-force format c)potential issue with my virtualbox?)

@keithorange
Copy link
Author

Update:
I had the virtualbox resolution set to ~1000px x 600px, I changed it to 1700px x 1250px, and now the map no longer works. If i remap this higher-quality resolution screen, would it still work fine? And this would probably help with OCR recognition as dpi is increased.

@timeyyy
Copy link

timeyyy commented Jul 31, 2023

i''ve found some potential causes of this. If i push a fix would you be willing to test it

@dickreuter
Copy link
Owner

dickreuter commented Jul 31, 2023 via email

@timeyyy timeyyy linked a pull request Aug 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants