New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish devise_lastseenable #4807
Comments
Hey, @jhass I would love to contribute to diaspora*, and I think I could take care of this issue :D Seems that https://github.com/ctide/devise_lastseenable would not be updated anymore last opened PR from 2017 is still open. If this new gem can't replace the devise_lastseenable, I could assume a new version and maintain it from now. What do you think @jhass ? |
Be my guest, I have no plans for it :) |
What makes 'last_seenable' better than device's 'trackable' ? https://www.rubydoc.info/github/heartcombo/devise/master/Devise/Models/Trackable |
Well, they solve different problems see the wardens hook for trackable https://github.com/heartcombo/devise/blob/c82e4cf47b02002b2fd7ca31d441cf1043fc634c/lib/devise/hooks/trackable.rb#L7 Devise's trackable will only update the user model after each "sign_in"/login etc. But the last_seen gem will mark a timestamp every time a @current_user is called. A real world example could be: trackable:
last_seen:
|
The makes sense - thanks for clarification |
devise_lastseenable is probably the most crufty dependency we have and it also seems unmaintained. It's a small nice project so polishing it would be a good task to embark ones own Ruby skills. List of things todo:
The text was updated successfully, but these errors were encountered: