Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch YAML specification errors #17

Open
4 tasks
beckydvn opened this issue Aug 30, 2023 · 2 comments
Open
4 tasks

Catch YAML specification errors #17

beckydvn opened this issue Aug 30, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@beckydvn
Copy link
Member

  • Raise exception if user tries to create a clarify action (through slot_fill or otherwise) for a context variable with a flag type known
  • Raise exception if the user uses names that would be invalid in PDDL (spaces, etc.)
  • Any actions with generated names (e.g. action names or intents from slot_fill) need to be checked against existing names in the YAML. Raise an exception if a duplicate occurs.
  • For slot_fill actions, enforce you can’t have single-slot specifications if you only have one entity
@beckydvn beckydvn added bug Something isn't working help wanted Extra attention is needed labels Aug 30, 2023
@haz
Copy link
Member

haz commented Aug 31, 2023

There already a dedicated place for confirming the yaml? These seem like a great start for what should be a common practice of scanning the yaml on ingestion.

@beckydvn
Copy link
Member Author

Right now it's just the parsing file that converts it to the hovor JSON. It would be ideal to have a "scan" before parsing anything, but for the "custom" actions that wouldn't work. So those exceptions would have to be handled within the parsing module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants