-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "known" values implicit when a value is changed to anything other than "none" #15
Comments
What happens when you don't specify anything? I.e., what's the default behaviour? |
Depends on if the "known" status is needed in another action or not 😉 In most cases the "known" setting is used as a precondition,, meaning that (currently) without adding it explicitly, the planner will likely not be able to find a plan. If it isn't needed, nothing would change, but in that case the context variable shouldn't have a "known" parameter. However, there is no harm to having one (just extra fluents for the planner to look at). |
No, not the downstream implications -- more directly to the value. Is the the |
Not sure I understand-- the "known" property is added (or omitted) by the user. If they added it with no value, the YAML wouldn't compile 🤔 |
I mean if they didn't include the known property at all, what would the impact of the action be? To retain whatever the know property was before the action was executed? |
Ah! I see what you mean. Yes, the previous value would be maintained, at least in terms of the plan generated. (I believe Hovor has some internal structure of "knowledge"-- e.g. IIRC if you set a "known" to False it automatically sets the value to null), but we want to make sure the plan itself takes knowledge into account |
Ah, got it. Then I'd flag this as a bug ;). |
When Plan4Dial becomes something more than just a YAML file, I imagine a system where they specify the context variable, and based on that they get the appropriate drop-downs ("known" = True, False, [or Maybe]) whenever they want to change the value 😉 But that's far and away... |
When explicitly defining an action, the
known
value has to be stated explicitly when a value is updated. Take this example from plan4dial'sbank_bot
:It's a small change, but it would be less mental overhead for the user if the system could infer that
known
be set to true when thevalue
is updated to something other thannone
.The text was updated successfully, but these errors were encountered: