Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I depend on puzzle-tools as a package? #1

Open
rspeer opened this issue Jan 13, 2015 · 2 comments
Open

Should I depend on puzzle-tools as a package? #1

rspeer opened this issue Jan 13, 2015 · 2 comments

Comments

@rspeer
Copy link

rspeer commented Jan 13, 2015

I've got solvertools and you've got puzzle-tools. It would seem to make sense for solvertools to depend on puzzle-tools for some things, such as normalizing names or getting IMDB lists. If I just copy the code into solvertools, it becomes harder for you to maintain, though.

Would it make sense to structure puzzle-tools as a Python package, with a setuptools setup.py at the top level, and all the code in the "puzzletools" directory? In that case I could straightforwardly make puzzle-tools a dependency.

@dgulotta
Copy link
Owner

That seems reasonable. I'm not too familiar with setuptools, so let me know if I did something incorrectly.

@rspeer
Copy link
Author

rspeer commented Jan 15, 2015

Thanks, the packaging works for me. I may not get to anything that uses it
as a dependency, but I do plan to have both packages installed.

On Tue Jan 13 2015 at 1:07:11 AM Daniel Gulotta notifications@github.com
wrote:

That seems reasonable. I'm not too familiar with setuptools, so let me
know if I did something incorrectly.


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants