Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Overlay Not Behaving The Same as Create React App's Overlay #35

Open
devloco opened this issue Jan 2, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working cosmetic

Comments

@devloco
Copy link
Owner

devloco commented Jan 2, 2020

Sometimes the error overlay looks wonky if you manually refresh the browser.
For example in App.tsx (note TypeScript) if you change line 3 to this (note the foo):

import foo "./App.css";

The initial overlay looks as expected. But then hit F5 to manually refresh and it looks very different.
Doing the same steps in a normal create-react-app project does not show the same behavior.

2020-01-01 21_27_23

Everything is still running properly, i.e. saving a file will still cause the browser to refresh. Even if the newly saved page has another error, it causes the error overlay to re-render properly. So this is really just a cosmetic bug.

@devloco devloco self-assigned this Jan 2, 2020
@devloco devloco added bug Something isn't working cosmetic labels Jan 2, 2020
@devloco
Copy link
Owner Author

devloco commented Feb 10, 2020

Just thinking about this... If I recall, I'm storing Webpack's last build result in the wpstart.js file... but probably mangling it some how. So if you manually refresh the browser, you're getting the mangled version of the build result.

There's a chance that fixing #41 will also fix this... so be sure to fix that one first, then test this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cosmetic
Projects
None yet
Development

No branches or pull requests

1 participant