Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn Users After Running wpbuild That Theme Will Look Broken on Dev Server #30

Open
devloco opened this issue Oct 13, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@devloco
Copy link
Owner

devloco commented Oct 13, 2019

If a user's dev server and prod server use differing paths for the root URL (a common setup) this can get confusing. Here's what happens:

  • The user ran npm run start and made some changes to their theme.
  • When they're done dev'ing, they run npm run build to make a production ready version of the theme.
  • If they refresh their browser (currently pointed at their dev instance) the browser will show a "missing stylesheet" error.

It'd be nice to warn them that this is expected behavior.

  • Themes built using npm run start will be broken on a production server.
  • Themes built using npm run build will be broken on a dev server.
@devloco devloco self-assigned this Oct 13, 2019
@devloco devloco added the enhancement New feature or request label Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant