Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict compare tool to overlapping AOI's #95

Open
LanesGood opened this issue Feb 1, 2024 · 3 comments
Open

Restrict compare tool to overlapping AOI's #95

LanesGood opened this issue Feb 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@LanesGood
Copy link
Member

This is a proposal for the compare tool, not yet established whether technically feasible, nor entered into the designs.

We know that the main use case for comparing prediction maps will be to look at change over time. This will most often and most likely be single users or related groups producing exported AOIs with the same imagery, model, and checkpoint, and changes in the mosaic.

It could be possible that users would want to compare LULC predictions from different imagery sources, different models, and different checkpoints.

However, it seems highly unlikely that users would want to compare any differences between these inputs in different geographies. It is difficult to imagine how this would be useful; in order to see prediction tiles on the share map, users must be zoomed in to the min-zoom, so it would not be possible to look in two areas that are far apart.

Would it be possible to restrict the compare tool to only AOI's that overlap? As we save the bounds for each AOI, I imagine we could run something like turf.js boolean instersect to determine which AOIs are eligible for comparison after the first AOI is selected. However, I recognize that this may be a complex operation to run over every possible available AOI and could require some complex engineering.

@vgeorge @geohacker what do you think?

@geohacker
Copy link
Member

@LanesGood I really like this idea but like you point out this will be computationally quite intensive on the frontend. We can try to implement after the compare functionality is implemented. The more efficient way is probably to have a endpoint on the backend that returns all available AOIs to compare for a selected AOI, but that's a bunch of work we may not have time for right now.

@LanesGood
Copy link
Member Author

For learning purposes, is it intensive because there is a property that needs to be compared to every other object, or is it mostly because its a geospatial operation?

@LanesGood LanesGood added the enhancement New feature or request label Feb 5, 2024
@geohacker
Copy link
Member

@LanesGood yes both, doing an intersect of one polygon to n number of other polygons is going to be both unpredictable and inefficient on the clientside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants