New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to select a template for an empty or missing gitignore #2197
Comments
I often run into this and wish there was a way to apply a I would like to propose something like the following:
New default tab state when no
New tab state when no From template selected and dropdown clicked
@sergiou87 @shiftkey would you accept a PR implementing this? Please forgive my slightly wonky screenshots - my photo editing skills are fairly basic. |
Hi @donokuda ! Thank you for your suggestion. We discussed about this and we're definitely open to accept PRs, but we think your approach might conflict a bit with how .gitignore is supposed to work: handling the file manually or from a template shouldn't be an (exclusive) option. Instead, users should be able to create a .gitignore file from a template and then edit it manually. With that in mind, we think it's better to detect when the .gitignore file is empty, and then show something to allow the user creating a .gitignore file from a template. That something might be, for example (we're open to suggestions), some kind of hint text here: Once the .gitignore file is not empty anymore, that something would be removed and you can just edit the file manually. What do you think? |
Sure that's probably even simpler. In my original proposal, the user would have to save with the template selected and then go back into the repo dialog to edit it (and since there would be a It sounds like your proposal is to allow the user to make immediate edits without having to save first. If so, when does the To flesh out this idea: If the If the |
Hello, I would like to work on this issue, if it's avaiable. |
go for it imo |
@sergiou87 Is help still needed on this issue? |
@bytrangle you're welcome to work on this! |
@sergiou87 @bytrangle Is anyone still working on this issue? If not, could I jump in? |
Just to clarify the behavior of the approach @sergiou87 laid out. I'm thinking the something between the label and the text field should be a dropdown menu where the user can select a gitignore template. This dropdown selection would default to "None." Once the user selects a template, the text field is automatically populated with that template, and the user has the ability to make further edits. This is slightly different from what @nycdotnet laid out, so let me know how this sounds to anyone on the team. Also, as I understand it, we don't want this dropdown menu to show up when the gitignore is not empty, correct? |
Any updates on this? Just wanted to make sure this task is available and clear the design before I start working on this. |
|
From #2160 (comment)
The text was updated successfully, but these errors were encountered: