Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wifite crash for python3 --crack #157

Open
RaduNico opened this issue Oct 18, 2018 · 1 comment · May be fixed by #219
Open

Wifite crash for python3 --crack #157

RaduNico opened this issue Oct 18, 2018 · 1 comment · May be fixed by #219

Comments

@RaduNico
Copy link

RaduNico commented Oct 18, 2018 •
edited 

 sudo python3 Wifite.py --crack 
 [+] Listing captured handshakes from /home/radunico/hs:

  NUM  ESSID (truncated)  BSSID              TYPE   DATE CAPTURED
  ---  -----------------  -----------------  -----  -------------------
    1  ShittyNet -snip- PMKID  2018-10-14 14:29:06
 [+] Select handshake(s) to crack (1-1, select multiple with , or - or all): 1

 [!] Error: dictionary changed size during iteration

 [!] Full stack trace below

 [!]    Traceback (most recent call last):
 [!]    File "/home/radunico/sec/wifite/my_wifite2/wifite/__main__.py", line 102, in entry_point
 [!]        wifite.start()
 [!]    File "/home/radunico/sec/wifite/my_wifite2/wifite/__main__.py", line 50, in start
 [!]        CrackHelper.run()
 [!]    File "/home/radunico/sec/wifite/my_wifite2/wifite/util/crack.py", line 64, in run
 [!]        for tool, dependencies in available_tools.items():
 [!]    RuntimeError: dictionary changed size during iteration

 [!] Exiting

Running wifite --crack under python3 while having a missing dependency (aircrack, john, cowpatty, hashcat) will result in this crash error. The issue is utiil/crack.py, a dictionary is created with all the dependecies and if one is missing, the values is popped from the dict. While in python 2 this is not an issue in python 3 it results in a crash.

I will make a fix for this issue tomorrow morning.
@kimocoder
Copy link
Contributor

Great. I suggest these "crashes" should have better output on what's really going on and possibly a solution on the matter. Great find, sure @derv82 return soon.

RaduNico added a commit to RaduNico/wifite2 that referenced this issue Oct 19, 2018
@RaduNico
util/crack: Fix python3 --crack crash
084a658 
Wifite would crash if run with python3 and the parameter --crack
if a dependency was missing, just after selecting a target.
This was caused by popping from a dictionary while iterating on
it, an operation forbidden in python3. Issue described in derv82#157

Signed-off-by: Radu Nicolau <radunicolau102@gmail.com>
@RaduNico RaduNico mentioned this issue Oct 19, 2018
Open
RaduNico added a commit to RaduNico/wifite2 that referenced this issue Feb 26, 2019
@RaduNico
util/crack: Fix python3 --crack crash
d56ca52 
Wifite would crash if run with python3 and the parameter --crack
if a dependency was missing, just after selecting a target.
This was caused by popping from a dictionary while iterating on
it, an operation forbidden in python3. Issue described in derv82#157

Signed-off-by: Radu Nicolau <radunicolau102@gmail.com>
@Snawoot Snawoot linked a pull request Apr 29, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wifite crack mode crash on python3
2 participants
@kimocoder @RaduNico