Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-valid-attr-value should not fail aria-controls when aria-haspopup is used #4363

Closed
WilcoFiers opened this issue Mar 7, 2024 · 0 comments · Fixed by #4418
Closed

aria-valid-attr-value should not fail aria-controls when aria-haspopup is used #4363

WilcoFiers opened this issue Mar 7, 2024 · 0 comments · Fixed by #4418
Assignees
@gaiety-deque
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Milestone
Axe-core 4.9.1

Comments

@WilcoFiers
Copy link
Contributor

Axe reports the following as an issue under aria-valied-attr-value because the #settings element doesn't exist until the button is activated.

<button aria-haspopup="true" aria-controls="settings">
  Settings
</button>

Axe-core has logic that allows this when aria-expanded="false" is on the button, but not without it. I think this exception should be extended to elements with aria-haspopup. Perhaps here it would be appropriate to report it as needs review instead of pass. We don't know whether the control is expanded or not.
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Mar 7, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone Mar 7, 2024
gaiety-deque added a commit that referenced this issue Apr 19, 2024
@gaiety-deque
fix(aria-valid-attr-value): aria-controls & aria-haspopup incomplete
551ba24 
if an element has both aria-controls and aria-haspopup mark it incomplete as we are unsure if the DOM element will be added dynamically later

Refs: #4363
@gaiety-deque gaiety-deque mentioned this issue Apr 19, 2024
Merged
gaiety-deque added a commit that referenced this issue Apr 23, 2024
@gaiety-deque
fix(aria-valid-attr-value): more thorough test coverage
a823712 
- messageKey added to unit test
- integration test

Refs: #4363
gaiety-deque added a commit that referenced this issue Apr 29, 2024
@gaiety-deque
fix(aria-valid-attr-value): aria-controls & aria-haspopup incomplete (#…
ef1e09d 
…4418)

if an element has both aria-controls and aria-haspopup mark it
incomplete as we are unsure if the DOM element will be added dynamically
later

**dev note**: this is my first time adding some language locale for an
incomplete, how's it look?

fix: #4363
@attest-team-ci attest-team-ci mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaiety-deque gaiety-deque

Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
Milestone
Axe-core 4.9.1
Development

Successfully merging a pull request may close this issue.

fix(aria-valid-attr-value): aria-controls & aria-haspopup incomplete dequelabs/axe-core
2 participants
@WilcoFiers @gaiety-deque