Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on windows fails in 4.9.0 #4407

Closed
1 task done
EvilKarter opened this issue Apr 12, 2024 · 3 comments · Fixed by #4409
Closed
1 task done

build on windows fails in 4.9.0 #4407

EvilKarter opened this issue Apr 12, 2024 · 3 comments · Fixed by #4409
Labels
ci Continuous Integration or build issues fix Bug fixes

Comments

@EvilKarter
Copy link
Contributor

EvilKarter commented Apr 12, 2024

Product

axe-core

Product Version

4.9.0

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

A valid build/tasks/metadata-function-map.js like in version 4.8.4

// This file is automatically generated using build/tasks/metadata-function-map.js
import abstractroleEvaluate from '../../checks/aria/abstractrole-evaluate.js';
import ariaAllowedAttrEvaluate from '../../checks/aria/aria-allowed-attr-evaluate.js';
....

const metadataFunctionMap = {
  'abstractrole-evaluate': abstractroleEvaluate,
  'accesskeys-after': accesskeysAfter,
....

Actual

build fails with
Running "esbuild:core" (esbuild) task > lib/core/base/metadata-function-map.js:2:11: error: Syntax error "c"

// This file is automatically generated using build/tasks/metadata-function-map.js
import lib\checks\visibility\hiddenContentEvaluate from '../../../lib\checks\visibility\hidden-content-evaluate.js';
import lib\checks\tables\thHasDataCellsEvaluate from '../../../lib\checks\tables\th-has-data-cells-evaluate.js';
....

const metadataFunctionMap = {
  'lib\checks\aria\abstractrole-evaluate': lib\checks\aria\abstractroleEvaluate,
  'lib\checks\aria\aria-allowed-attr-evaluate': lib\checks\aria\ariaAllowedAttrEvaluate,
....

How to Reproduce

Build on windows with

npm run build -- --lang=de

Additional context

i think it is something with an upgraded dependency, because all buits in older versions are still working and I see nothing in the changelog that seems like an cause.

@EvilKarter EvilKarter added the ungroomed Ticket needs a maintainer to prioritize and label label Apr 12, 2024
@straker
Copy link
Contributor

straker commented Apr 15, 2024

Thanks for the issue. While I work on debugging this could I ask what version of node you're running?

@straker straker added fix Bug fixes ci Continuous Integration or build issues and removed ungroomed Ticket needs a maintainer to prioritize and label labels Apr 15, 2024
@straker
Copy link
Contributor

straker commented Apr 15, 2024

We found the issue. In v4.9.0 we switched from globby to glob. Turns out glob on windows returns the path with double slashes which when passed to path.basename directly wasn't working. We have a fix in progress that will normalize the paths and fix a few other instances where glob returned paths in a format we weren't expecting on windows.

@EvilKarter
Copy link
Contributor Author

node -v
v20.8.1

straker pushed a commit that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration or build issues fix Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants