Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Add PHAR file and a signature to Release Process #143

Closed
szepeviktor opened this issue Aug 31, 2020 · 8 comments
Closed

Add PHAR file and a signature to Release Process #143

szepeviktor opened this issue Aug 31, 2020 · 8 comments

Comments

@szepeviktor
Copy link

szepeviktor commented Aug 31, 2020

From #122

Dear @TomasVotruba!

Please upload

  1. a PHAR file
  2. and its signature to releases as attachments

The singing key has to be published on keyservers once.

This way phive install migrify/migrify will simply work.

@szepeviktor
Copy link
Author

szepeviktor commented Aug 31, 2020

I see! There is no box config to just generate PHAR files :(

@szepeviktor
Copy link
Author

https://github.com/humbug/box generates PHAR files automatically.

e.g.

phive install --force-accept-unsigned humbug/box
tools/box compile --working-dir=packages/class-presence

@szepeviktor
Copy link
Author

Should there be several PHAR-s? One for each package??

@TomasVotruba
Copy link
Member

Should there be several PHAR-s? One for each package??

Yes, for each package you need this way 👍

migrify/migrify is a monorepo, like symfony/symfony, so you should never use it directly, just particular packages

@szepeviktor
Copy link
Author

szepeviktor commented Aug 31, 2020

Would you like to upload release attachments (thus PHAR files + signatures) manually or in GitHub Actions?

@TomasVotruba
Copy link
Member

That would be tedious with every tag. This process must be automated

@TomasVotruba
Copy link
Member

Closing as accepted and only PR is needed. To keep more space for active issues, that need attention to resolve.

Thanks for understanding.

@szepeviktor
Copy link
Author

Okay.

Here we make a GitHub Action phar-io/phive#278

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants