Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio Revision is not supported #62

Open
4 tasks done
josh-thisisbud opened this issue Nov 28, 2023 · 0 comments · May be fixed by #63
Open
4 tasks done

Istio Revision is not supported #62

josh-thisisbud opened this issue Nov 28, 2023 · 0 comments · May be fixed by #63
Labels
kind/enhancement kind - new features or changes priority/medium priority - should be fixed before next release but won't block
Milestone

Comments

@josh-thisisbud
Copy link

Checks

  • I have searched the existing issues.
  • This request is NOT specific to the CLI. (If so, please open an issue on the CLI repo)

Motivation

To fit deployKF alongside existing infrastructure, we require the ability to set the Istio revision

Implementation

Something like

    {{- if .Values.deploykf_dependencies.istio.revision }}
    istio.io/rev: {{ .Values.deploykf_dependencies.istio.revision }}
    {{- else }}
    istio-injection: enabled
    {{- end }}

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@josh-thisisbud josh-thisisbud added kind/enhancement kind - new features or changes priority/needs-triage priority - needs to be triaged labels Nov 28, 2023
@thesuperzapper thesuperzapper added priority/medium priority - should be fixed before next release but won't block and removed priority/needs-triage priority - needs to be triaged labels Dec 13, 2023
@thesuperzapper thesuperzapper added this to the v0.3.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes priority/medium priority - should be fixed before next release but won't block
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants