Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 Error is displayed when clicking on Recent Notebooks #150

Open
3 tasks done
cmarquezrusso opened this issue May 10, 2024 · 0 comments
Open
3 tasks done

403 Error is displayed when clicking on Recent Notebooks #150

cmarquezrusso opened this issue May 10, 2024 · 0 comments
Labels
kind/bug kind - things not working properly priority/needs-triage priority - needs to be triaged

Comments

@cmarquezrusso
Copy link

cmarquezrusso commented May 10, 2024

Checks

deployKF Version

0.1.4

Kubernetes Distribution

EKS

Kubernetes Version

Client Version: v1.28.7
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.3-eks-adc7111

Description

Steps to reproduce:

  • Create three new Notebooks instances, called
  • test-403-empty: Do not add/create files here. lost+found will be created automatically
  • test-403-notebook: add a jupyter notebook called 403.ipynb
  • test-403.txt: add a new txt file called 403.txt
  • Refresh deployKF Dashboard. You should see 3 lost+foundlinks 403.txt and 403.ipynb
  • Click on the 5 links, opening on a new tab.
  • The lost+found will display the 403 error
  • The 403.txt will show an empty file
  • The 403.ipynb will show an empty notebook with Jupyter interface.
  • Go back to the deployKF Dashboard
  • Click in one of the lost+found links
  • This will show a 403 error in the same page
  • Clicking on any other deploykf section will fail with the same error
  • Clicking on a working notebook will also trigger the same error

Expected Result:

  • Clicking on lost+found should open the notebook in that directory.
  • A 403 error should not crash functionality

Workaround: Refresh and do not click on lost+found.

Update: Seems like the issue is the link of the iframe:
deployKF will try: https://deploykf/notebook/team-1/test-403-notebook/files/lost+found which causes the error.

I manually modified the link and this one works.

https://deploykf/notebook/team-1/test-403-notebook/lab/tree/lost%2Bfound

Relevant Logs

-n team-1 logs -f -l apps.kubernetes.io/pod-index=0 --max-log-requests 100000
[W 2024-05-10 00:34:44.898 ServerApp] 403 GET /notebook/team-1/test-403-notebook/files/ (127.0.0.6):  is not a file
[W 2024-05-10 00:34:44.900 ServerApp] 403 GET /notebook/team-1/test-403-notebook/files/ (127.0.0.6) 2.25ms referer=None

deployKF Values (Optional)

I am using the default apps-of-apps, exposing using Ingress for AWS LB.
@cmarquezrusso cmarquezrusso added kind/bug kind - things not working properly priority/needs-triage priority - needs to be triaged labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind - things not working properly priority/needs-triage priority - needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant