Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to Kubeflow Pipelines 2.1.0 #122

Merged

Conversation

thesuperzapper
Copy link
Member

closes: #115
related: #65

This PR updates to Kubeflow Pipelines 2.1.0. We have made a small fork of Kubeflow Pipelines, with the only difference from upstream being that ours will work with external S3/MinIO object stores, see https://github.com/deployKF/kubeflow-pipelines for more information about our fork. Hopefully, once kubeflow/pipelines#10625 makes its way into a release, we won't need our fork anymore.

First, please note that this implementation of Kubeflow Pipelines 2.0 is backward-compatible with runs compiled by the KFP V1 SDK (in both v1 and v2-compatible modes).

Second, I would like to highlight that our custom images are still ONLY built for linux/amd64, and are not able to run on ARM yet, see the upstream issue for more information kubeflow/pipelines#10309.

Finally, here are a bunch of technical details about how I got Kubeflow Pipelines 2.0 to work:

  • The kubeflow_tools.pipelines.kfpV2.minioFix value has been removed:

  • The default kubeflow_tools.pipelines.kfpV2.defaultPipelineRoot is now {scheme}://{bucket_name}/v2/artifacts/{profile_name}?region={bucket_region}&endpoint={endpoint}&disableSSL={not_use_ssl}&s3ForcePathStyle=true:

  • you should ignore most changes under ./generator/templates/manifests/kubeflow-tools/pipelines/upstream because it's mostly because we have moved to consuming the manifests directly from kubeflow/pipelines, rather than kubeflow/manifests and they structure their folders differently. Furthermore, we use a lot of patches/removals, so most of those manifests don't actually make it to the final render

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the v0.1.5 milestone Apr 21, 2024
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

thesuperzapper commented May 3, 2024

It looks like KFP just released a v2.2.0 version.

We should review if we need to update this PR to use that version: https://github.com/kubeflow/pipelines/releases/tag/2.2.0

It give us is the ability to use Argo Workflow 3.4 (kubeflow/pipelines#10568), but its not clear if all the issues are actually resolved:

The main thing we need to check is that V1 pipelines are not broken.

@thesuperzapper thesuperzapper merged commit 3710b41 into deployKF:main May 23, 2024
3 checks passed
@thesuperzapper thesuperzapper deleted the update-to-kubeflow-pipelines-2.1 branch May 23, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 Pipeline fails looking for MinIO secret
1 participant