Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE | Profile | Direct Deposit | Handle Lighthouse timeout error #83237

Open
3 tasks
Tracked by #73922
tpharrison opened this issue May 16, 2024 · 4 comments
Open
3 tasks
Tracked by #73922

BE | Profile | Direct Deposit | Handle Lighthouse timeout error #83237

tpharrison opened this issue May 16, 2024 · 4 comments
Assignees
Labels
authenticated-experience VA.gov authenticated experience backend bug Something isn't working direct deposit profile

Comments

@tpharrison
Copy link
Contributor

Background

Lighthouse timeouts are not being handled correctly by the lighthouse service exception class.

Kris Pathtel discovered this issue and has applied a fix for direct deposit, but suggested we discuss and apply a more global solution.

Tasks

  • Review potential solutions for addressing the timeout solution.
  • Apply patch.

Acceptance Criteria

  • Test in mock environment.
@tpharrison tpharrison self-assigned this May 16, 2024
@mtcA6 mtcA6 changed the title BE | Profile | Direct Deposit | Handle timeout error BE | Profile | Direct Deposit | Handle Lighthouse timeout error May 16, 2024
@mtcA6
Copy link
Contributor

mtcA6 commented May 16, 2024

@tpharrison what's the LH service exception class?

what sort of global solution would work better? Is this something we should discuss w LH? Are there other applications that need to consider these changes too?

cc: @ACParker89

@mtcA6 mtcA6 added the bug Something isn't working label May 16, 2024
@tpharrison
Copy link
Contributor Author

@mtcA6 This is just a code patch on our end. LH doesn't need to be involved. The fix is contained to the services that use the exception class. It's just our team, mobile, and benefit disabilities. I'm keeping the engineers in the loop on this. It should be a straightforward fix.

@tpharrison
Copy link
Contributor Author

This issue has been fixed for direct deposit, but it may affect other services. The benefits disabilities team seems to own most of the code that might be affected. I reached out to Aurora Hampton and Mark Chae to discuss a more robust fix for this issue.

@mtcA6
Copy link
Contributor

mtcA6 commented Jun 4, 2024

Do we need to track the larger fix and move this to blocked or validate for that larger fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authenticated-experience VA.gov authenticated experience backend bug Something isn't working direct deposit profile
Projects
None yet
Development

No branches or pull requests

2 participants