Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE | Profile | Failing unit tests in CI/CD for Update Address specs #77636

Closed
1 task
Tracked by #73922
adamwhitlock1 opened this issue Mar 5, 2024 · 2 comments
Closed
1 task
Tracked by #73922
Assignees
Labels

Comments

@adamwhitlock1
Copy link
Contributor

adamwhitlock1 commented Mar 5, 2024

Issue Description

Look into tests that are currently skipped within our application and platform folder for profile

See PR department-of-veterans-affairs/vets-website#28295

Also this PR where some more profile and platform vap-svc tests are skipped:
department-of-veterans-affairs/vets-website#28403

located in src/applications/personalization/profile/tests/components/contact-information/PersonalInformation.update-address.unit.spec.jsx

Updating
       Mailing address when the entered address passes address validation
         should show an error and not auto-exit edit mode if the transaction fails quickly:
     Unable to find an element by: [data-testid="edit-error-alert"]

 Updating
       Home address when the entered address passes address validation
         should show an error and not auto-exit edit mode if the transaction fails quickly:
     Unable to find an element by: [data-testid="edit-error-alert"]

We need to fix these tests and investigate into why they started failing but pass locally.

Also look into the tests that were mentioned here: https://dsva.slack.com/archives/C04868KS69L/p1709656491174279?thread_ts=1709598204.845519&cid=C04868KS69L

Front end tasks

  • Fix tests
  • Ensure they pass in CI/CD
  • Document fix

Acceptance Criteria

  • All unit tests pass in CI/CD
@mtcA6
Copy link
Contributor

mtcA6 commented May 8, 2024

going to double check this in sprint 36 and then close out if we've already fixed since we may have already fixed this 🎉

@adamwhitlock1
Copy link
Contributor Author

I updated these tests recently and they are no longer flakey. Closing this ticket out as it is no longer needed. If I see them start to fail in the CI/CD I will revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants