Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: Uncaught (in promise) Error: not implemented p.kill("SIGKILL") #140

Open
vsmahesh opened this issue Oct 10, 2021 · 2 comments
Open
Labels
bug Something isn't working

Comments

@vsmahesh
Copy link

vsmahesh commented Oct 10, 2021

I am getting the following exception in the console

[*] [daem] restarting due to changes...
error: Uncaught (in promise) Error: not implemented
p.kill("SIGKILL");
^
at deno:core/01_core.js:106:46
at unwrapOpResult (deno:core/01_core.js:126:13)
at Object.opSync (deno:core/01_core.js:140:12)
at opKill (deno:runtime/js/40_process.js:18:10)
at Process.kill (deno:runtime/js/40_process.js:92:7)
at Daemon.killAll (https://deno.land/x/denon@2.4.9/src/daemon.ts:92:11)
at Daemon.reload (https://deno.land/x/denon@2.4.9/src/daemon.ts:35:10)
at Daemon.iterate (https://deno.land/x/denon@2.4.9/src/daemon.ts:181:22)
at iterate.next ()
at https://deno.land/x/denon@2.4.9/denon.ts:167:20.

  • OS: windows 10
  • Deno version: deno 1.14.1 (release, x86_64-pc-windows-msvc) v8 9.4.146.15 typescript 4.4.2
  • Denon version: v2.4.9
@vsmahesh vsmahesh added the bug Something isn't working label Oct 10, 2021
@ghost
Copy link

ghost commented Oct 23, 2021

I got an installation error also related to "SIGKILL"

$ deno install -qAf --unstable https://deno.land/x/denon/denon.ts
error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'number'.
        p.kill("SIGKILL");
               ~~~~~~~~~
    at https://deno.land/x/denon@2.4.9/src/daemon.ts:92:16

TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'number'.
        p.kill("SIGKILL");
               ~~~~~~~~~
    at https://deno.land/x/denon@2.4.9/src/daemon.ts:96:16

TS2724 [ERROR]: 'Deno' has no exported member named 'Signal'. Did you mean 'signal'?
      const signs: Deno.Signal[] = [
                        ~~~~~~
    at https://deno.land/x/denon@2.4.9/src/daemon.ts:149:25

Found 3 errors.

did deno upgrade and tried again - that worked 👍

@nnmrts
Copy link
Contributor

nnmrts commented Nov 23, 2021

denon 2.4.9 is incompatible with deno 1.16, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants