Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostImportModuleDynamicallyCallback arguments undocumented #1349

Open
ldanilek opened this issue Oct 21, 2023 · 0 comments
Open

HostImportModuleDynamicallyCallback arguments undocumented #1349

ldanilek opened this issue Oct 21, 2023 · 0 comments

Comments

@ldanilek
Copy link

The docstring for HostImportModuleDynamicallyCallback says

The referrer contains metadata about the script/module that calls import.

but there is no argument called referrer in the example code. The arguments resource_name and host_defined_options appear in the example but are not described.

i figured out the arguments by looking at the C++ docs which passes a ScriptOrModule called referrer, which contains HostDefinedOptions and ResourceName. this could be clearer in the rust docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant