Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Address Bar wont update after 303 redirect response. #2404

Open
MitchMcKean opened this issue Apr 13, 2024 · 4 comments
Open

Client Address Bar wont update after 303 redirect response. #2404

MitchMcKean opened this issue Apr 13, 2024 · 4 comments
Labels
bug Something isn't working.

Comments

@MitchMcKean
Copy link

The correct Page will load but the Address Bar is still showing the last Page.
At the API the status 303 is used with a new location header.

@CAYdenberg
Copy link
Contributor

Can you show us how you are issuing the redirect and how you are testing it? Because as read this is a description of unexpected behaviour by your browser, not Fresh.

@MitchMcKean MitchMcKean closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
@MitchMcKean
Copy link
Author

Yes of course. I hope I am not wasting anyone's time by this maybe being a problem with my browser.
So if I hit a page directly by typing the address and the page response is a redirect, everything works fine and maybe I am wrong and this is also expected behavior but if I send a request to the Fresh Server and the response is a redirect, the address bar wont change but the page will load as expected.

So I am trying to use a Form for Login like this

export const handler: Handlers = {
  async GET(req: Request, ctx: FreshContext) {
    return await ctx.render();
  },
  async POST(req: Request, ctx: FreshContext) {
    const form = await req.formData();
    const email = form.get("email")?.toString();
    const password = form.get("password")?.toString();

    console.log(`Login for ${email} with ${password}`);

    const headers = new Headers();
    headers.set("location", "/posts");
    return new Response(null, {
      status: 303,
      headers,
    });
  },
};

export default function Login() {
  return (
    <>
      <Head>
        <title>Login</title>
      </Head>
      <div className="flex flex-wrap w-full max-w-sm bg-emerald-950 rounded-lg mt-24 p-4 mx-auto">
        <h1 className="text-4xl font-extrabold mx-auto">Login</h1>
        <div className="py-4 w-full">
          <form method="POST">
            <label
              className="block text-red-100 text-base uppercase font-bold mb-1"
              htmlFor="email"
            >
              EMail
            </label>
            <input
              type="email"
              id="email"
              name="email"
              className="w-full border bg-gray-800/50 rounded px-3 py-2 outline-none text-white"
            />
            <label
              className="block text-red-100 text-base uppercase font-bold mb-1 mt-4"
              htmlFor="password"
            >
              password
            </label>
            <input
              type="password"
              id="password"
              name="password"
              className="w-full border bg-gray-800/50 rounded px-3 py-2 outline-none text-white"
            />
            <div class="flex w-full justify-center pt-4">
              <button
                type="submit"
                className="relative bg-emerald-500 border border-transparent hover:border-emerald-200 py-2 px-6 rounded-md font-bold text-lg text-white"
              >
                Sign In / Login
              </button>
            </div>
          </form>
        </div>
      </div>
    </>
  );
}

@MitchMcKean MitchMcKean reopened this Apr 14, 2024
@marvinhagemeister
Copy link
Collaborator

Thanks for sharing the reproduction code. That made it a lot easier to understand what your scenario is, what happened and what you did expect to happen. Can confirm that this is a bug.

@marvinhagemeister marvinhagemeister added the bug Something isn't working. label Apr 15, 2024
@MitchMcKean
Copy link
Author

could it also be that in this case of a redirect, fresh also does not load any islands that are related to that page that the redirect is pointing to. Only those island exist, that already have been loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

3 participants