Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: move std/fmt/colors to std/cli/styles #4676

Open
iuioiua opened this issue May 6, 2024 · 2 comments
Open

suggestion: move std/fmt/colors to std/cli/styles #4676

iuioiua opened this issue May 6, 2024 · 2 comments
Labels
suggestion a suggestion yet to be agreed

Comments

@iuioiua
Copy link
Collaborator

iuioiua commented May 6, 2024

I suggest moving/renaming std/fmt/colors to std/cli/styles for the following reasons:

  1. The module contains functionality for more than just colors. I.e. italic() and bold(). Hence, the rename to styles.
  2. The module's functionality is only concerned with console output. Hence, the move to std/cli.
    This new name would make far more sense than it currently does and be much more accurate.

This is a continuation of the conversation happening in #4326.

@iuioiua iuioiua added the suggestion a suggestion yet to be agreed label May 6, 2024
@andrewthauer
Copy link
Contributor

What about std/cli/ansi instead?

@iuioiua
Copy link
Collaborator Author

iuioiua commented May 6, 2024

What about std/cli/ansi instead?

We think std/cli/styles would be better. See #4326 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion a suggestion yet to be agreed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants