suggestion(semver): remove redundant increment()
arguments
#4420
Labels
feedback welcome
We want community's feedback on this issue or PR
increment()
arguments
#4420
Is your feature request related to a problem? Please describe.
increment()
has four arguments (two required, two optional). That is more than the style guide suggests.buildmetadata
just seem to replace the semver build property.prerelease
as a string kinda breaks the established pattern of prerelease being an(string|number)[]
array and needs to be parsed insideincrement()
. It doesn't seem very intuitive, how that argument works in combination withReturnType
and existingversion.prerelease
. This is why the majority of the jsdoc description tries to explain that.Describe the solution you'd like
buildmetadata
argument, asversion.build
can be set outside theincrement()
function.prerelease
argument, asversion.prerelease
can be set outside theincrement()
function.Describe alternatives you've considered
Leave as is.
The text was updated successfully, but these errors were encountered: