feat: support analysis of require() statements
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Nov 11, 2021
kitsonk
changed the title
require() statementsrequire() statements
bartlomieju
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
LGTM, only one nitpick. I think we should wait on upgrade to deno_ast before landing this PR (denoland/deno_ast#46)
Comment on lines
+310
to
+314
| impl Default for DependencyKind { | ||
| fn default() -> Self { | ||
| Self::Import | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it required to implement Default trait for this enum? It feels to me like a potential footgun that might lead to discrepancies by too liberal use of Default::default() somewhere in the call chain.
|
@kitsonk is there anything I can do to help you to land this PR? |
|
It needs quite a bit of rebasing... let me take care of it. We just didn't need it before, now there is a compelling need. |
|
Stale and uneeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
The PR allows the
deno_graphto statically analyserequire()statements in modules and have them exist as part of the module graph. There are some limitations, which are swc limitations:require()symbol in code and does not track re-assignment. Meaning it won't find dependencies likeconst r = require; const b = r("b");.require()function, therefore things likeconst m = "m"; require(m);do not work.This is a BREAKING CHANGE on the Rust side, but one that shouldn't impact any of the CLI functionality. Essentially
Resolver::resolve()andLoader::load()now take an extra argument which indicates what kind of dependency it is. This allows consumers to be able to branch logic in code based on the "reason" the resolution or loading is occurring. On the JavaScript side, it is a non-breaking change, since excess arguments are ignorable.