Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CommonJs dependency analysis #58

Open
kitsonk opened this issue Oct 29, 2021 · 0 comments
Open

Support CommonJs dependency analysis #58

kitsonk opened this issue Oct 29, 2021 · 0 comments
Assignees
@kitsonk
Labels
enhancement New feature or request

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Oct 29, 2021

swc already supports parsing this out (we just simply discard those nodes at the moment), but I think the best way we can identify them in the graph is to add a is_require to the resolved dependency and pass it in the load() method, like we do with is_dynamic.

I will work on a PR for it. Makes me feel a bit 🤢 though 😉.
@kitsonk kitsonk added the enhancement New feature or request label Oct 29, 2021
@kitsonk kitsonk self-assigned this Oct 29, 2021
kitsonk added a commit to kitsonk/deno_graph that referenced this issue Nov 10, 2021
@kitsonk
feat: support analysis of require() statements
16e325f 
Closes denoland#58
@kitsonk kitsonk mentioned this issue Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support analysis of require() statements kitsonk/deno_graph
1 participant
@kitsonk