Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow option to run with --check #177

Open
kyeotic opened this issue May 25, 2022 · 3 comments
Open

allow option to run with --check #177

kyeotic opened this issue May 25, 2022 · 3 comments

Comments

@kyeotic
Copy link

kyeotic commented May 25, 2022

Deno has a flag to run without type-checking, which is useful for lambdas that have already been type-checked. There are already several DENO ENV VARs to configure behavior, a DENO_NOCHECK or more flexible DENO_FLAGS would be useful here.
@hayd
Copy link
Contributor

hayd commented May 25, 2022 •
edited

Currently --no-check is always passed:

https://github.com/hayd/deno-lambda/blob/b2e02b0158282b200cbc5e2bd238403cb22b1ed6/runtime/bootstrap#L22

happy to submission of this, BUT I think --no-check is deprecated and deno is moving to --check (so flag should be DENO_CHECK). Potentially we should support --check=all etc.

denoland/deno#14691

@hayd hayd changed the title allow option to run with --no-check allow option to run with --check May 25, 2022
@kyeotic
Copy link
Author

kyeotic commented May 26, 2022

Sounds good

@kyeotic kyeotic closed this as completed May 26, 2022
@hayd hayd reopened this May 26, 2022
@hayd
Copy link
Contributor

hayd commented May 26, 2022

Will keep this open til it's implemented :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyeotic @hayd