Snapshot failing on freenas-nfs-api (response.body.children is not iterable)

[jlpedrosa]

When trying to create an snapshot of an nfs volume, I got some errors on the events.

Failed to check and update snapshot content: failed to take snapshot of the volume pvc-1b411f39-8386-49ec-ae32-8b5e96de1c67: "rpc error: code = Internal desc = TypeError: response.body.children is not iterable TypeError: response.body.children is not iterable\n    at FreeNASApiDriver.CreateSnapshot (/home/csi/app/src/driver/freenas/api.js:4041:43)\n    at 

inspecting the logs I see:

{"host":"kube-system-democratic-csi-nfs-controller-c5b86fbfd-gw52h","level":"info","message":"new request - driver: FreeNASApiDriver method: CreateSnapshot call: {\"path\":\"/csi.v1.Controller/CreateSnapshot\",\"metadata\":{},\"request\":{\"secrets\":\"redacted\",\"parameters\":{},\"source_volume_id\":\"pvc-1b411f39-8386-49ec-ae32-8b5e96de1c67\",\"name\":\"snapshot-fa779853-80ee-4c45-94a4-b482e33d498a\"},\"pendingStatus\":{\"code\":0,\"details\":\"OK\"},\"cancelled\":false,\"trailingMetadata\":{}}","service":"democratic-csi","timestamp":"2024-04-01T10:47:52.046Z"}
{"host":"kube-system-democratic-csi-nfs-controller-c5b86fbfd-gw52h","level":"error","message":"handler error - driver: FreeNASApiDriver method: CreateSnapshot error: TypeError: response.body.children is not iterable TypeError: response.body.children is not iterable\n    at FreeNASApiDriver.CreateSnapshot (/home/csi/app/src/driver/freenas/api.js:4041:43)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async requestHandlerProxy (/home/csi/app/bin/democratic-csi:222:18)","service":"democratic-csi","timestamp":"2024-04-01T10:47:52.069Z"}
{"host":"kube-system-democratic-csi-nfs-controller-c5b86fbfd-gw52h","level":"info","message":"new request - driver: FreeNASApiDriver method: GetPluginInfo call: {\"path\":\"/csi.v1.Identity/GetPluginInfo\",\"metadata\":{},\"request\":{},\"pendingStatus\":{\"code\":0,\"details\":\"OK\"},\"cancelled\":false,\"trailingMetadata\":{}}","service":"democratic-csi","timestamp":"2024-04-01T10:47:52.124Z"}

here the definition of the snapshot (describe):

Name:         velero-homeassistant-homeassistant-0-ktmtt
Namespace:    homeassistant
Labels:       app.kubernetes.io/instance=homeassistant-homeassistant
              app.kubernetes.io/name=home-assistant
              velero.io/backup-name=freenas-test-backup
Annotations:  <none>
API Version:  snapshot.storage.k8s.io/v1
Kind:         VolumeSnapshot
Metadata:
  Creation Timestamp:  2024-04-01T10:47:51Z
  Finalizers:
    snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
    snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
  Generate Name:     velero-homeassistant-homeassistant-0-
  Generation:        1
  Resource Version:  415557
  UID:               fa779853-80ee-4c45-94a4-b482e33d498a
Spec:
  Source:
    Persistent Volume Claim Name:  homeassistant-homeassistant-0
  Volume Snapshot Class Name:      freenas-nfs-csi
Status:
  Bound Volume Snapshot Content Name:  snapcontent-fa779853-80ee-4c45-94a4-b482e33d498a
  Error:
    Message:     Failed to check and update snapshot content: failed to take snapshot of the volume pvc-1b411f39-8386-49ec-ae32-8b5e96de1c67: "rpc error: code = Internal desc = TypeError: response.body.children is not iterable TypeError: response.body.children is not iterable\n    at FreeNASApiDriver.CreateSnapshot (/home/csi/app/src/driver/freenas/api.js:4041:43)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async requestHandlerProxy (/home/csi/app/bin/democratic-csi:222:18)"
    Time:        2024-04-01T10:47:52Z
  Ready To Use:  false
Events:
  Type    Reason            Age    From                 Message
  ----    ------            ----   ----                 -------
  Normal  CreatingSnapshot  8m48s  snapshot-controller  Waiting for a snapshot homeassistant/velero-homeassistant-homeassistant-0-ktmtt to be created by the CSI driver.

Final notes:

• I'm on RC1 of Truenas: OS Version:TrueNAS-SCALE-24.04-RC.1
• freenas-api-iscsi works just fine