We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I was looking at the code and it seems like starts_with may not be the ideal method here (or maybe some level of canonicalisation would be good):
roo_on_rails/lib/roo_on_rails/rack/populate_env_from_jwt.rb
Line 78 in 29d664e
Example: http://trusted.com/.well-known/../bad/another_file.json starts_with? http://trusted.com/.well-known/ http://trusted.com/.well-known/../bad/another_bug starts_with? http://trusted.com/.well-known/ http://trusted.com@example.org starts_with? http://trusted.com
One good thing is that your http client configuration doesn't follow redirect so it makes exploitation a lot harder.
It may also be good to enforce the scheme to https in
Line 96 in 29d664e
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I was looking at the code and it seems like starts_with may not be the ideal method here (or maybe some level of canonicalisation would be good):
roo_on_rails/lib/roo_on_rails/rack/populate_env_from_jwt.rb
Line 78 in 29d664e
Example:
http://trusted.com/.well-known/../bad/another_file.json starts_with? http://trusted.com/.well-known/
http://trusted.com/.well-known/../bad/another_bug starts_with? http://trusted.com/.well-known/
http://trusted.com@example.org starts_with? http://trusted.com
One good thing is that your http client configuration doesn't follow redirect so it makes exploitation a lot harder.
It may also be good to enforce the scheme to https in
roo_on_rails/lib/roo_on_rails/rack/populate_env_from_jwt.rb
Line 96 in 29d664e
The text was updated successfully, but these errors were encountered: