Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: It will use the same version number and not appending -num to duplicate when in add media other than the media page itself #638

Open
kentliau opened this issue Jan 12, 2024 · 1 comment
Labels

Comments

@kentliau
Copy link

kentliau commented Jan 12, 2024

Describe the bug
Uploading a image with Advance Custom Field of same file name will cause the plugin to reuse the same version number. And due to I use AWS CloudFront to cache the image, therefore the url will maintain the old image for some time.

Actually it also happen on normal post, the "add media" button.

To Reproduce
Steps to reproduce the behavior:

  • Go add a new post/page > add media
  • Upload image of the same filename

Expected behavior

  • Use different version number
  • Or append -1 -2 -3 to the file name

UPDATE:

Is super weird, i tried everything, turn off plugin, reset the db table, everything possible can. And I eventually found out if my post/page year/month is the this year/month, it will rename the duplicate correctly. If any other year/month that is not this year/month will cause the bug to appear.

Conclusion:

It conflict with wordpress' native year/month folder setting, need to uncheck the box

@kentliau kentliau added the bug label Jan 12, 2024
@kentliau kentliau closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
@kentliau
Copy link
Author

kentliau commented Jan 12, 2024

me now find out it now appending -1 -2 -3 suffix to file name, but that is only on the media page

@kentliau kentliau reopened this Jan 12, 2024
@kentliau kentliau changed the title Bug: It will use the same version number if file name is the same Bug: It will use the same version number if file name is the same in ACF custom image field Jan 12, 2024
@kentliau kentliau changed the title Bug: It will use the same version number if file name is the same in ACF custom image field Bug: It will use the same version number and not appending -num to duplicate when in add media other than the media page itself Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant