New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to stop all animations of a gui node at the same time #6553
Comments
Good point. animation vs animations is inconsitent and I'm not sure why. In both cases you can only have one animation running per property on a game object or node.
I think I prefer this solution. Or the other way around and change to go.cancel_animation(url, [property]). I'd appreciate some input from @JCash as well. |
For now, I've implemented the first option. I don’t want to arbitrarily change function names until I get confirmation of it. The second option suggested by @britzl is that go.cancel_animation can also be good, maybe even better than the gui.cancel_animations I suggest. Feedback from @JCash would be helpful. |
The
But you can call Given the nature of the |
Excellent! Thanks @JCash ! @coderm4ster are you still up for completing this PR and making the necessary changes? |
Is your feature request related to a problem? Please describe (REQUIRED):
Referring to stopping all animations of the game object property at the same time, which was implemented by request #6492, this same could be done similarly on the gui nodes.
Describe the solution you'd like (REQUIRED):
Currently, the gui.cancel_animation function can be used to stop animations on a gui node. I don't know the reason, but it didn't get an "s" suffix compared to the go.cancel_animations function name (It confused me several times). Maybe it would be good to unify the two names.
Implementation can be done in several ways:
gui.cancel_animation(node, [property])
gui.cancel_animations(node)
gui.cancel_animations(node, [property])
Perhaps option 3 is the most appropriate.
The text was updated successfully, but these errors were encountered: