Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain record names will cause the record not to be written to storage. #13

Open
aokisok opened this issue Sep 23, 2016 · 3 comments
Open
Labels

Comments

@aokisok
Copy link

aokisok commented Sep 23, 2016

Record names that that map to a table name which contains invalid characters cause writes to storage to silently fail.

To reproduce:

var rec = ds.record.getRecord('foo-bar/32');
rec.set({x: 1});

At this point the record behaves normally as its in the cache, but it hasn't been written to storage, and on restart or cache eviction the record will be lost.

RethinkDB only allows A-z 0-9 and '_' in the table name which is what is causing this.

Note there is no error message when this happens. ( logLevel: DEBUG )

@Iiridayn
Copy link

Are you getting "undefined" messages in your output log? Those might be the error messages, masked.

@aokisok
Copy link
Author

aokisok commented Sep 29, 2016

Nope, no 'undefined' messages, just normal logging output at debug level, not indicating any problem.

@yasserf
Copy link
Contributor

yasserf commented Oct 4, 2016

This is a good find, we'll put it into the next release due end of next week

@yasserf yasserf added the bug label Oct 4, 2016
yasserf added a commit that referenced this issue Feb 12, 2017
Possible fix to #13, improves handling of splitChar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants