Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue:#3836-Fixing Handling of NoneType in default_generator Function #3847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

issue:#3836-Fixing Handling of NoneType in default_generator Function #3847

wants to merge 1 commit into from
+4 −1

Conversation

Harshith-07
Copy link

@Harshith-07 Harshith-07 commented Feb 22, 2024 •
edited

Description

Fix #3836

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@shreyasvinaya
Copy link
Member

Hi,
Could you please mention the issue as a part of the PR like #3836

@Harshith-07 Harshith-07 changed the title issue:3836-Fixing Handling of NoneType in default_generator Function issue:#3836-Fixing Handling of NoneType in default_generator Function Feb 27, 2024
@Harshith-07
Copy link
Author

Hey @shreyasvinaya, just wanted to let you know that I've made an update to the pull request description for clarity.

@shreyasvinaya
Copy link
Member

@rbharath could you please turn on the CI so that we can test this

@shreyasvinaya
Copy link
Member

Hi @Harshith-07, Could you please rebase this PR

@Harshith-07
Copy link
Author

Hey @shreyasvinaya, I'm a bit unclear about what you mean by "rebase this PR." Could you please elaborate on what you're asking for? I want to make sure I understand your request properly.

@shreyasvinaya
Copy link
Member

shreyasvinaya commented Mar 22, 2024 •
edited

@Harshith-07 you will have to pull the latest changes from the main repo . You can use this tutorial for your reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Training on datasets without y attribute (ex: unsupervised-learning) throws AttributeError
2 participants
@Harshith-07 @shreyasvinaya