Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify packages with tests executed without logger implementation #1606

Open
tfr42 opened this issue Nov 30, 2023 · 2 comments
Open

Identify packages with tests executed without logger implementation #1606

tfr42 opened this issue Nov 30, 2023 · 2 comments
Assignees
Labels
core deegree core modules tests unit/integration test

Comments

@tfr42
Copy link
Member

tfr42 commented Nov 30, 2023

Fix the broken test dependencies for missing logger implementation,

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Relates to #1587

@julianzz98
Copy link
Contributor

Affected modules are:

  • deegree-connectionprovider-datasource
  • deegree-core-base
  • deegree-core-commons
  • deegree-core-coverage
  • deegree-core-cs
  • deegree-core-featureinfo
  • deegree-core-geometry
  • deegree-core-layer
  • deegree-core-metadata
  • deegree-core-rendering-2d
  • deegree-core-style
  • deegree-core-tile
  • deegree-featurestore-memory
  • deegree-featurestore-sql
  • deegree-layers-feature
  • deegree-mdstore-ebrim-eo
  • deegree-mdstore-iso
  • deegree-mdstore-iso-memory
  • deegree-protocol-commons
  • deegree-protocol-csw
  • deegree-protocol-wfs
  • deegree-protocol-wms
  • deegree-protocol-wmts
  • deegree-remoteows-wmts
  • deegree-services-commons
  • deegree-services-wfs
  • deegree-services-wms
  • deegree-sqldialect-mssql
  • deegree-sqldialect-oracle
  • deegree-tilestore-filesystem

@tfr42 tfr42 added tests unit/integration test core deegree core modules labels Dec 1, 2023
@julianzz98 julianzz98 assigned tfr42 and unassigned julianzz98 Dec 1, 2023
@stephanr
Copy link
Member

In PR #1631 we added a stopgap measure to fill the logging gap fot the build system.
This, on the other hand, will not solve the issue completely as describes in #1631.

To cleanly solve this issue, all relevant deegree modules have to a have a correct test dependency to a logging implementation like slf4j-simple.

After this is done, the following block can be removed:

deegree3/pom.xml

Lines 150 to 156 in 6a51fcd

<additionalClasspathDependencies>
<additionalClasspathDependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>${slf4j.version}</version>
</additionalClasspathDependency>
</additionalClasspathDependencies>

And if slf4j-simple is not used also the following have to be removed:

deegree3/pom.xml

Lines 157 to 159 in 6a51fcd

<systemProperties>
<org.slf4j.simpleLogger.defaultLogLevel>warn</org.slf4j.simpleLogger.defaultLogLevel>
</systemProperties>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core deegree core modules tests unit/integration test
Projects
None yet
Development

No branches or pull requests

3 participants