Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous output value must be set at time of transaction creation #1176

Closed
jrick opened this issue Jun 11, 2018 · 1 comment
Closed

Previous output value must be set at time of transaction creation #1176

jrick opened this issue Jun 11, 2018 · 1 comment

Comments

@jrick
Copy link
Member

jrick commented Jun 11, 2018

One of the requirements for decred/dcrd#950 is for the wallet to set the previous output value in the transaction input that references the output. Currently this field is set by miners, but the new signature hash algorithm will use the input value for the signature calculation.

There are several places where transactions can be created by the wallet, so a full audit should be performed to ensure all are updated.

@jrick
Copy link
Member Author

jrick commented Sep 17, 2018

I believe this is fixed everywhere now, since wire.NewTxIn was modified to require the input amount.

@jrick jrick closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant