Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcr: Allow ticket purchasing for rpc spv wallets. #2611

Open
JoeGruffins opened this issue Nov 21, 2023 · 8 comments · May be fixed by #2756
Open

dcr: Allow ticket purchasing for rpc spv wallets. #2611

JoeGruffins opened this issue Nov 21, 2023 · 8 comments · May be fixed by #2756

Comments

@JoeGruffins
Copy link
Member

JoeGruffins commented Nov 21, 2023

The biggest blocker for this is that currently the GetTickets rpc call will not work over rpc with an spv wallet. That will need to be "fixed" over in dcrwallet. The second problem is that, if a vsp is not set, purchasing will fail, and we currently have no way to know if an spv vsp is set. If it's ok to just fail sometimes, maybe with a message asking the user to make sure a vsp is set, then maybe that's fine. Maybe we can also add some data to GetTickets or a new command to see if a vsp is currently set.

@buck54321
Copy link
Member

Maybe we can also add some data to GetTickets or a new command to see if a vsp is currently set.

Maybe add a field to the walletinfo response?

@JoeGruffins
Copy link
Member Author

Maybe add a field to the walletinfo response?

I think this is what I initially suggested to @jrick but maybe we can now.

@jrick
Copy link
Member

jrick commented Nov 22, 2023

just opened decred/dcrwallet#2305 which adds the result to getinfo.

But also now I'm seeing that a similar field was already added to walletinfo, so I'm not sure if this is even needed (a "spv" field is set to true if it's currently syncing with the spv syncer).

@jrick
Copy link
Member

jrick commented Nov 22, 2023

The second problem is that, if a vsp is not set, purchasing will fail, and we currently have no way to know if an spv is set

ah, this typo threw me off (spv instead of vsp...).

Gonna close the above pr then since the issue is only about detecting vsp settings, afaict.

@jrick
Copy link
Member

jrick commented Nov 22, 2023

decred/dcrwallet#2306

@JoeGruffins
Copy link
Member Author

ah, this typo threw me off (spv instead of vsp...).

srry... I do that a lot.

@buck54321
Copy link
Member

The biggest blocker for this is that currently the GetTickets rpc call will not work over rpc with an spv wallet.

decred/dcrwallet#2321

@JoeGruffins
Copy link
Member Author

@buck54321 I guess we need to use master to have those changes? I attempted to use master with the simnet harness but decred/dcrwallet#2340 is causing wallet sync to stop.

@JoeGruffins JoeGruffins linked a pull request May 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants