-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark comments as resolved #154
Comments
This is done! |
Sorry to bring this up. Maybe I'm missing something. |
The only options on the github gui are 'add a reaction', 'change', and 'delete'. There is no 'resolve'. |
Since only reviews can be marked as resolved, I guess this is still pending. |
Yes, this simple feature would greatly speed up my workflow when resolving comments! |
As with many other issues in this repository, this is a duplicate of an issue already filed in |
Comments on issues can be marked as resolved as of not too long ago |
@koenpunt commented on 1 Aug 2018, 21:00 BST:
True but this is missing lots more details, which are covered in the issue of which this is a duplicate. IMHO this is another example of many that this repository is damaging the GitHub community by unnecessarily fragmenting it. I have tried to help fix that but unfortunately my PR has been ignored. |
In the meantime, Revieable.io can do this and a bunch of other neat tricks... (I am not affiliated with Reviewable other than being a very happy user.) |
I'm going to close this as I don't think GitHub will (in the short term) be adding this and because the current features already allow more then when this was opened. Should anyone have a different opinion, they can raise their own issue. |
What's the recommended etiquette to follow when closing an issue when we want to mark it as resolved? For instance, if it were a bug, should I remove the label "bug" when it's resolved? |
It would be nice if we could have an option to mark comments on PRs as resolved so they'd be collapsed or dimmed.
The text was updated successfully, but these errors were encountered: