Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and keep only one version. #12

Open
luca-heltai opened this issue Apr 14, 2017 · 4 comments
Open

Clean up and keep only one version. #12

luca-heltai opened this issue Apr 14, 2017 · 4 comments

Comments

@luca-heltai
Copy link
Member

Following @tjhei advice, I'd like to clean this repository, and keep only very few versions of deal.II around. I think it is now reasonable to stick only to candi for the full version.

I propose to keep only the following images with the given Dockerfile showing the dependencies

What you do you think? Any other suggestion/opinion on the naming structure?

@tjhei
Copy link
Member

tjhei commented Apr 14, 2017

  1. Should we include the word "serial" or "min" or something in the name for the last two images? This could be the same as we will do for the macosx installers.
  2. I am fine with removing "-candi" from the name of the full images
  3. VER=vX.X.X - here master also works, right?

@luca-heltai
Copy link
Member Author

luca-heltai commented Apr 18, 2017

1+2: How about this:

dealii/dealii:latest = dealii:v8.5.0-gcc-mpi

dealii/dealii:v8.5.0-clang-serial (bare deal.II, serial, both debug and release)
dealii/dealii:v8.5.0-gcc-serial (bare deal.II, serial, both debug and release)
dealii/dealii:v8.5.0-gcc-mpi (all possible dependencies, both debug and release)
dealii/dealii:v8.5.0-gcc-mpi (all possible dependencies, both debug and release)

and possibly, for smaller images:

dealii/dealii:v8.5.0-clang-serial-debug
dealii/dealii:v8.5.0-clang-serial-release
dealii/dealii:v8.5.0-gcc-mpi-debug
dealii/dealii:v8.5.0-gcc-mpi-release

  1. Yes, but that changes in time. I'd use short sha1 for specific releases, i.e.,

f0ce4e9-clang-serial-release
f0ce4e9-clang-serial-debug

This would require a total of 4 Docker files: gcc-serial, gcc-mpi, clang-serial and clang-mpi, with two build args: VER, and BUILD_TYPE. These files should be identical except for the FROM instruction (unless we want to explicitly turn on all features, in which case also the deal.II build command should be different).

@luca-heltai
Copy link
Member Author

ping @tjhei

@luca-heltai
Copy link
Member Author

maybe we could replace serial and mpi with minimal and full. It is obvious that minimal is serial (with no external deps) and full is parallel, with all dependencies. Comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants