You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since PetscInt is a signed integer, we should always
make a copy (no reinterpret_cast<PetscInt *>)
do a range check (since, for 32-bit indices, the maximum range is significantly different)
If we're doing both, then we don't need to restrict ourselves to matching DEAL_II_WITH_64BIT_INDICES and sizeof(PetscInt) == 8. That would simplify the CI set up a bit (and make things easier for users).
The text was updated successfully, but these errors were encountered:
This is from slack.
Since
PetscInt
is a signed integer, we should alwaysreinterpret_cast<PetscInt *>
)If we're doing both, then we don't need to restrict ourselves to matching
DEAL_II_WITH_64BIT_INDICES
andsizeof(PetscInt) == 8
. That would simplify the CI set up a bit (and make things easier for users).The text was updated successfully, but these errors were encountered: