Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the restrictions on 64-bit PETSc. #16528

Open
drwells opened this issue Jan 23, 2024 · 2 comments
Open

Relax the restrictions on 64-bit PETSc. #16528

drwells opened this issue Jan 23, 2024 · 2 comments

Comments

@drwells
Copy link
Member

drwells commented Jan 23, 2024

This is from slack.

Since PetscInt is a signed integer, we should always

  1. make a copy (no reinterpret_cast<PetscInt *>)
  2. do a range check (since, for 32-bit indices, the maximum range is significantly different)

If we're doing both, then we don't need to restrict ourselves to matching DEAL_II_WITH_64BIT_INDICES and sizeof(PetscInt) == 8. That would simplify the CI set up a bit (and make things easier for users).

@bangerth
Copy link
Member

Perhaps via a convert_to_PetscInt() function, rather than always doing it by hand in all places necessary?

@drwells
Copy link
Member Author

drwells commented Jan 23, 2024

That's a good idea

@tamiko tamiko added this to the Release 9.6 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants