Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRF 3.14 removes NullBooleanField #35

Open
jayvdb opened this issue Oct 5, 2022 · 4 comments · May be fixed by #36
Open

DRF 3.14 removes NullBooleanField #35

jayvdb opened this issue Oct 5, 2022 · 4 comments · May be fixed by #36

Comments

@jayvdb
Copy link

jayvdb commented Oct 5, 2022

All use now fails with

[   36s] ============================= test session starts ==============================
[   36s] platform linux -- Python 3.8.14, pytest-7.1.2, pluggy-1.0.0 -- /usr/bin/python3.8
[   36s] cachedir: .pytest_cache
[   36s] django: settings: tests.settings (from env)
[   36s] rootdir: /home/abuild/rpmbuild/BUILD/django-rest-framework-braces-0.3.4
[   36s] plugins: django-4.5.2
[   37s] collecting ... collected 40 items / 5 errors / 1 deselected / 39 selected
[   37s] 
[   37s] ==================================== ERRORS ====================================
[   37s] ___________ ERROR collecting drf_braces/tests/fields/test_custom.py ____________
[   37s] drf_braces/tests/fields/test_custom.py:9: in <module>
[   37s]     from ...fields.custom import (
[   37s] drf_braces/fields/__init__.py:3: in <module>
[   37s]     from ._fields import *  # noqa
[   37s] drf_braces/fields/_fields.py:45: in <module>
[   37s]     get_updated_fields(FIELDS, (EmptyStringFieldMixin, AllowBlankNullFieldMixin))
[   37s] drf_braces/fields/_fields.py:37: in get_updated_fields
[   37s]     fields = [globals()[i] for i in fields]
[   37s] drf_braces/fields/_fields.py:37: in <listcomp>
[   37s]     fields = [globals()[i] for i in fields]
[   37s] E   KeyError: 'NullBooleanField'
@jayvdb jayvdb mentioned this issue Oct 5, 2022
Open
@faroukbmiled
Copy link

is there any solution to this?

danigm added a commit to danigm/django-rest-framework-braces that referenced this issue Nov 2, 2022
@danigm
Revmoe NullBooleanField
f3e9b57 
Fix dealertrack#35
@danigm danigm linked a pull request Nov 2, 2022 that will close this issue
Open
@umangsh
Copy link

umangsh commented Mar 5, 2023

@danigm fix seems appropriate. How soon can it be merged? Still affecting builds.

@umangsh
Copy link

umangsh commented Mar 7, 2023

@miki725 for visibility.
Are there any temporary workarounds?

@Sergecodes
Copy link

still facing this issue 1yr later ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revmoe NullBooleanField danigm/django-rest-framework-braces
4 participants
@jayvdb @umangsh @faroukbmiled @Sergecodes