/
test_form_serialzier.py
347 lines (262 loc) · 11 KB
/
test_form_serialzier.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
from __future__ import absolute_import, print_function, unicode_literals
import unittest
from collections import OrderedDict
from datetime import datetime
import mock
import six
from django import forms
from rest_framework import fields, serializers
from ...serializers.form_serializer import (
FormSerializer,
FormSerializerBase,
FormSerializerFieldMixin,
FormSerializerMeta,
FormSerializerOptions,
LazyLoadingValidationsMixin,
make_form_serializer_field,
)
TESTING_MODULE = 'drf_braces.serializers.form_serializer'
class TestForm(forms.Form):
foo = forms.CharField(max_length=12)
bar = forms.IntegerField(max_value=500)
happy = forms.ChoiceField(required=False)
other = forms.DateTimeField()
def __init__(self, *args, **kwargs):
super(TestForm, self).__init__(*args, **kwargs)
self.fields['happy'].choices = [
('happy', 'choices'),
]
def clean(self):
data = super(TestForm, self).clean()
data.update({
'bar': 257,
})
return data
class TestFormSerializerFieldMixin(unittest.TestCase):
def setUp(self):
super(TestFormSerializerFieldMixin, self).setUp()
class Field(FormSerializerFieldMixin, fields.IntegerField):
pass
class Serializer(serializers.Serializer):
field = Field()
class Meta(object):
minimum_required = []
failure_mode = 'fail'
self.serializer = Serializer()
self.field = self.serializer.fields['field']
def test_run_validation_invalid(self):
with self.assertRaises(fields.ValidationError):
self.field.run_validation('a')
def test_run_validation_invalid_failure_mode(self):
self.serializer.partial = True
with self.assertRaises(fields.ValidationError):
self.field.run_validation('a')
def test_run_validation_invalid_required_field(self):
self.serializer.partial = True
self.serializer.Meta.failure_mode = 'drop'
self.serializer.Meta.minimum_required = ['field']
with self.assertRaises(fields.ValidationError):
self.field.run_validation('a')
def test_run_validation_skip(self):
self.serializer.partial = True
self.serializer.Meta.failure_mode = 'drop'
self.serializer.Meta.minimum_required = []
with self.assertRaises(fields.SkipField):
self.field.run_validation('a')
class TestUtils(unittest.TestCase):
def test_make_form_serializer_field(self):
field_class = make_form_serializer_field(fields.IntegerField)
self.assertEqual(field_class.__name__, 'IntegerFormSerializerField')
self.assertTrue(issubclass(field_class, FormSerializerFieldMixin))
class TestFormSerializerOptions(unittest.TestCase):
def test_init(self):
meta = mock.Mock(failure_mode='fail', foo='bar')
options = FormSerializerOptions(meta, 'foo')
self.assertEqual(options.form, meta.form)
self.assertEqual(options.failure_mode, 'fail')
self.assertEqual(options.minimum_required, meta.minimum_required)
self.assertEqual(options.field_mapping, meta.field_mapping)
self.assertEqual(options.foo, meta.foo)
def test_init_invalid(self):
with self.assertRaises(AssertionError):
FormSerializerOptions(mock.Mock(failure_mode='foo'), 'foo')
with self.assertRaises(AssertionError):
FormSerializerOptions(mock.Mock(form=None), 'foo')
with self.assertRaises(NotImplementedError):
FormSerializerOptions(mock.Mock(failure_mode='ignore'), 'foo')
class TestFormSerializerMeta(unittest.TestCase):
@mock.patch(TESTING_MODULE + '.FormSerializerOptions')
def test_no_parents(self, mock_form_serializer_options):
class TestSerializer(six.with_metaclass(FormSerializerMeta, serializers.Serializer)):
pass
self.assertFalse(mock_form_serializer_options.called)
def test_no_meta(self):
with self.assertRaises(AssertionError):
class TestSerializer(six.with_metaclass(FormSerializerMeta, FormSerializer)):
pass
def test_new(self):
class TestSerializer(six.with_metaclass(FormSerializerMeta, FormSerializer)):
class Meta(object):
form = TestForm
self.assertIsInstance(TestSerializer.Meta, FormSerializerOptions)
self.assertIs(TestSerializer.Meta.form, TestForm)
class TestFormSerializerBase(unittest.TestCase):
def setUp(self):
super(TestFormSerializerBase, self).setUp()
class Serializer(FormSerializerBase):
other = fields.CharField()
class Meta(object):
failure_mode = 'drop'
form = TestForm
minimum_required = ['foo']
field_mapping = {}
self.serializer_class = Serializer
def test_init(self):
serializer = self.serializer_class()
self.assertTrue(serializer.partial)
def test_get_form(self):
serializer = self.serializer_class()
form = serializer.get_form()
self.assertIsInstance(form, TestForm)
self.assertIn('foo', form.fields)
self.assertIn('bar', form.fields)
self.assertIn('other', form.fields)
self.assertTrue(form.fields['foo'].required)
self.assertFalse(form.fields['bar'].required)
self.assertFalse(form.fields['other'].required)
def test_get_fields(self):
serializer = self.serializer_class()
serializer.Meta.field_mapping.update({
forms.CharField: fields.BooleanField,
})
serializer_fields = serializer.get_fields()
self.assertIsInstance(serializer_fields, OrderedDict)
self.assertIn('foo', serializer_fields)
self.assertIn('bar', serializer_fields)
self.assertIn('other', serializer_fields)
self.assertIsInstance(serializer_fields['foo'], fields.BooleanField)
self.assertIsInstance(serializer_fields['bar'], fields.IntegerField)
self.assertIsInstance(serializer_fields['other'], fields.CharField)
def test_get_fields_excluded(self):
serializer = self.serializer_class()
serializer.Meta.exclude = ['foo']
serializer.Meta.field_mapping.update({
forms.CharField: fields.BooleanField,
})
serializer_fields = serializer.get_fields()
self.assertIsInstance(serializer_fields, OrderedDict)
self.assertNotIn('foo', serializer_fields)
def test_get_fields_not_mapped(self):
serializer = self.serializer_class()
class FooField(forms.Field):
pass
class FooForm(TestForm):
stuff = FooField()
serializer.Meta.form = FooForm
with self.assertRaises(TypeError):
serializer.get_fields()
def test_get_field(self):
serializer = self.serializer_class()
form_field = forms.ChoiceField(
choices=[('foo', 'bar')],
required=False,
validators=[mock.sentinel.validator],
)
field = serializer._get_field(form_field, fields.ChoiceField)
self.assertIsInstance(field, fields.ChoiceField)
self.assertTrue(field.allow_blank)
self.assertTrue(field.allow_null)
self.assertListEqual(field.validators, [mock.sentinel.validator])
self.assertDictEqual(field.choice_strings_to_values, {
'foo': 'foo',
})
def test_get_field_kwargs(self):
serializer = self.serializer_class()
form_field = forms.IntegerField(
max_value=500,
initial=100,
required=True,
validators=[mock.sentinel.validator],
)
kwargs = serializer._get_field_kwargs(form_field, fields.IntegerField)
self.assertDictContainsSubset({
'default': 100,
'validators': [mock.sentinel.validator, mock.ANY],
}, kwargs)
self.assertNotIn('required', kwargs)
def test_get_field_kwargs_choice_field(self):
serializer = self.serializer_class()
form_field = forms.ChoiceField(
choices=[('foo', 'FOO'), ('bar', 'BAR')]
)
kwargs = serializer._get_field_kwargs(form_field, fields.ChoiceField)
self.assertDictContainsSubset({
'choices': OrderedDict([
('foo', 'foo'),
('bar', 'bar'),
]),
}, kwargs)
def test_validate(self):
serializer = self.serializer_class(data={
'foo': 'hello',
'bar': '100',
'other': 'stuff',
})
self.assertTrue(serializer.is_valid())
self.assertDictEqual(serializer.validated_data, {
'foo': 'hello',
'bar': 257,
'happy': '',
})
def test_validate_valid(self):
serializer = self.serializer_class(data={
'foo': 'hello',
'bar': '100',
'other': '2015-01-01 12:30',
})
self.assertTrue(serializer.is_valid())
self.assertDictEqual(serializer.validated_data, {
'other': datetime(2015, 1, 1, 12, 30),
'foo': 'hello',
'bar': 257,
'happy': '',
})
def test_validate_fail(self):
self.serializer_class.Meta.failure_mode = 'fail'
serializer = self.serializer_class(data={
'foo': 'hello',
'bar': '100',
'other': 'stuff',
})
self.assertFalse(serializer.is_valid())
self.assertDictEqual(serializer.errors, {
'other': ['Enter a valid date/time.'],
})
def test_to_representation(self):
with self.assertRaises(NotImplementedError):
self.serializer_class().to_representation({})
class TestFormSerializer(unittest.TestCase):
def test_bases(self):
self.assertTrue(issubclass(FormSerializer, FormSerializerBase))
self.assertIsInstance(FormSerializer, FormSerializerMeta)
class TestLazyLoadingValidationsMixin(unittest.TestCase):
def setUp(self):
super(TestLazyLoadingValidationsMixin, self).setUp()
class Serializer(LazyLoadingValidationsMixin, FormSerializer):
class Meta(object):
form = TestForm
self.serializer_class = Serializer
def test_repopulate_form_fields(self):
serializer = self.serializer_class()
# sanity check
self.assertDictEqual(serializer.fields['happy'].choices, {})
serializer.repopulate_form_fields()
self.assertDictEqual(dict(serializer.fields['happy'].choices), {'happy': 'happy'})
self.assertDictEqual(dict(serializer.fields['happy'].choice_strings_to_values),
{'happy': 'happy'})
@mock.patch.object(serializers.Serializer, 'to_internal_value')
@mock.patch.object(LazyLoadingValidationsMixin, 'repopulate_form_fields')
def test_to_internal_value(self, mock_repopulate_form_fields, mock_super_to_internal_value):
serializer = self.serializer_class()
serializer.to_internal_value({})
mock_repopulate_form_fields.assert_called_once_with()