Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not explicitly set the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php #6090

Open
1 task done
klonos opened this issue Apr 13, 2024 · 1 comment · May be fixed by #6091
Open
1 task done

Comments

@klonos
Copy link
Contributor

klonos commented Apr 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Expected Behavior

With a Backdrop DDEV recipe, when setting backdrop_drupal_compatibility or update_free_access in settings.php or settings.local.php (which unlike Drupal is provided by default OOTB in Backdrop), the Drupal compatibility layer should respect that setting.

Actual Behavior

Because backdrop_drupal_compatibility and update_free_access are also explicitly set in settings.ddev.php (see https://github.com/ddev/ddev/blob/master/pkg/ddevapp/drupal/backdrop/settings.ddev.php#L21), and because the DDEV settings file is loaded last, the desired settings as configured for the site never take (they are always overridden by the DDEV settings.php file). That is not expected behavior, and it should be left up to the defaults set by your Backdrop version (the backdrop_drupal_compatibility setting for instance is enabled by default in Backdrop 1.x but planned to be disabled by default in 2.x).

Steps To Reproduce

  1. Install a vanilla Backdrop CMS site using the DDEV recipe.
  2. Edit your settings.php file or the settings.local.php file and set $settings['backdrop_drupal_compatibility'] = FALSE;.
  3. Try reading that setting via settings_get('backdrop_drupal_compatibility') (for instance using the devel module and dpm() or something) -> regardless of how that setting is configured, it is always returned as TRUE 👎🏼
@klonos klonos changed the title Do not explicitly enable the backdrop_drupal_compatibility setting in settings.ddev.php Do not explicitly enable the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php Apr 13, 2024
@klonos klonos changed the title Do not explicitly enable the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php Do not explicitly set the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php Apr 13, 2024
klonos added a commit to klonos/ddev that referenced this issue Apr 13, 2024
@klonos
Copy link
Contributor Author

klonos commented Apr 13, 2024

PR for this here: #6091 (I hope I did everything right - this is my first PR for this project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant