Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"test this PR on Gitpod" should open a more generic project, not just "drupal10" #6014

Open
1 task done
tyler36 opened this issue Mar 25, 2024 · 7 comments
Open
1 task done

Comments

@tyler36
Copy link
Collaborator

tyler36 commented Mar 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior

I want a "clean" environment so I can follow a quickstart guide.

Idealy, the link opens a workspace with only DDEV configured and installed. Developers can then follow a quickstart guide to keep things minimal and lean.

I can see the benefit of a preinstalled environment so perhaps we could offer both?

"You can also test this PR in a clean Gitpod or with a simple Drupal 10 project.

  • Wording a work-in-progress.

Actual Behavior

After clicking the "test this PR on Gitpod" link, it created a workspace that installed, configured and started the Drupal Umami demo.

This is great for developers that are familiar with Drupal. However:

  • not everyone is familiar Drupal
  • adds additional overhead to install/configure/import a Drupal installation when it may not be needed
  • additional hdd, cpu cycles used that may not be needed.

For new developers this could raise some questions:

  • Is it better to stop the project before trying to start a new one?
  • Where should I put my new project?
  • Will the 2 projects conflict? (No, thats we are using DDEV)

Steps To Reproduce

  1. Visit feat: add cakephp project type, fixes #5713 #5888
  2. Click the test this PR on Gitpod.

Anything else?

No response

@tyler36
Copy link
Collaborator Author

tyler36 commented Mar 25, 2024

Related to #5989

@tyler36
Copy link
Collaborator Author

tyler36 commented Mar 25, 2024

Yes, getting errors now:

  1. Stop d10simple and make new project
ddev stop
cd ..
mkdir my-cakephp-app
cd my-cakephp-app
  1. Configure project
$ ddev config --project-type=cakephp --docroot=webroot --create-docroot --php-version=8.3
Configuration complete. You may now run 'ddev start'.
$ ddev composer create--prefer-dist cakephp/app:~5.0
Failed to start workspace: host port 3306 has already been allocated to project d10simple

@rfay
Copy link
Member

rfay commented Mar 25, 2024

You have to do a ddev delete -Oy d10simple normally on gitpod, because it's all set up to do one project at a time (and the exposed ports all default to the same).

@rfay
Copy link
Member

rfay commented Mar 25, 2024

The gitpod setup here is built around building the ddev executable, not around having a proper project to test. I don't think we could succeed at that.

I'm happy to walk through the steps though.

@tyler36
Copy link
Collaborator Author

tyler36 commented Mar 25, 2024

You have to do a ddev delete -Oy d10simple normally

That would work. Not sure best way to communicate that to new developers though.

@rfay
Copy link
Member

rfay commented Mar 25, 2024

Most of the time people just need a random site to work with. What we could do is replace d10simple with a trivial php project with an index.php I guess. And maybe the index.php could say what to do to go forward.

This is done by https://github.com/ddev/ddev/blob/master/.gitpod.yml

It's not hard to do it with a simple php repo, and then tell people how to override what they have there.

Interested in experimenting with it?

@tyler36
Copy link
Collaborator Author

tyler36 commented Mar 25, 2024

If I have free time, I'll play around. New business year starts next week, so not sure how far I will get.

@rfay rfay changed the title "test this PR on Gitpod" should open to generic container. "test this PR on Gitpod" should open a more generic project, not just "drupal10" Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants