Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove docs and test for #ddev-nodisplay #5969

Open
1 task done
hanoii opened this issue Mar 13, 2024 · 5 comments
Open
1 task done

docs: Remove docs and test for #ddev-nodisplay #5969

hanoii opened this issue Mar 13, 2024 · 5 comments

Comments

@hanoii
Copy link
Collaborator

hanoii commented Mar 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

No response

Expected Behavior

I searched the code and found one test but I think all this stanza behavior was removed from ddev, not sure if by accident of on purpose. So if it was removed on purpose, probably worth removing it altogether and fixing https://github.com/ddev/ddev-addon-template/blob/main/install.yaml

project-wide search of #ddev-nodisplay

Searching 5610 files for "ddev-nodisplay"

~/Sites/work/ddev/cmd/ddev/cmd/testdata/TestCmdGetComplex/recipe/install.yaml:
    3  pre_install_actions:
    4  - |
    5:   #ddev-nodisplay
    6    echo "This action should not have any output"
    7  - |

~/Sites/work/ddev/docs/content/users/extend/additional-services.md:
  102  In any stanza of `pre_install_actions` and `post_install_actions` you can:
  103  
  104: * Use `#ddev-nodisplay` on a line to suppress any output.
  105  * Use `#ddev-description:<some description of what stanza is doing>` to instruct DDEV to output a description of the action it's taking.
  106  

2 matches across 2 files

Actual Behavior

n/a

Steps To Reproduce

No response

Anything else?

No response

@rfay
Copy link
Member

rfay commented Mar 13, 2024

It's used extensively in ddev/ddev-platformsh

https://github.com/ddev/ddev-platformsh/blob/main/install.yaml

@hanoii
Copy link
Collaborator Author

hanoii commented Mar 13, 2024

I am just saying it doesn't appear that there's code on ddev that does anything with it.

@hanoii
Copy link
Collaborator Author

hanoii commented Mar 13, 2024

@hanoii
Copy link
Collaborator Author

hanoii commented Mar 13, 2024

I found some of it was added on 80a2907

But that logic is not currently anywhere.

@rfay
Copy link
Member

rfay commented Mar 13, 2024

You're right of course.

I see it was removed in

(git log -S 'ddev-generated')

I think it turned out that the output was rarely useful, but I would think I would note it in the PR.

I guess if it could be removed for nearly a year and a half and nobody noticed maybe we don't need it.

@rfay rfay changed the title is #ddev-nodisplay still a thing for add-ons? Remove docs and testt for #ddev-nodisplay Mar 13, 2024
hanoii added a commit to hanoii/ddev-platformsh-lite that referenced this issue Mar 13, 2024
@rfay rfay changed the title Remove docs and testt for #ddev-nodisplay docs: Remove docs and test for #ddev-nodisplay Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants