Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Config form: Adding widget to assist the user on filling the properties #4054

Open
shral opened this issue May 4, 2023 · 2 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@shral
Copy link
Member

shral commented May 4, 2023

If the user needs to add some properties, for example like IID_PATIENT_URL or STOWWebApp etc, while configuring the WebApp it would be good to get a dropdown with all valid parameters.

@shral shral added the enhancement New feature or request label May 4, 2023
@shral shral added this to the 5.31.0 milestone May 4, 2023
@shral shral self-assigned this May 4, 2023
@gunterze
Copy link
Member

gunterze commented May 4, 2023

Another option we may think about is to move configuration from general WebApp properties, to particular attributes of a UIWebApp child object in the UI configuration tree, referenced by the WebApp name (dcmWebAppName).

@vrindanayak
Copy link
Member

Web Application Properties are independent of UI using a specific web application or not, even though agree that web apps were introduced for our UI. For eg. w.r.t. STOWWebApp specific property pointing to STOW_RS web application (used by CD Import function) is essentially nowhere displayed for usage by UI at all.

Currently this issue is more about providing easy-to-add properties using a widget wherever dcmProperty is used in other parts of configuration schemas in the archive (eg. exporter / export rule / storage etc.). As part of fulfilling #4027 the web application properties are now seen and select-able in other configuration schemas, which is misleading.

Also, uiWebApp.schema.json describes itself as Web App drop-down list which means it is not limited to one web app and is intended for serving some other purpose. I vote for renaming / updating uiWebApp.schema.json to indicate its real intended use instead.

@gunterze gunterze modified the milestones: 5.31.0, 5.31.1 Aug 23, 2023
@gunterze gunterze modified the milestones: 5.31.1, 5.31.2 Nov 3, 2023
@gunterze gunterze modified the milestones: 5.31.2, 5.31.3 Dec 21, 2023
@gunterze gunterze modified the milestones: 5.32.0, 5.32.1 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants